Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Long.js conversion of i64 with JS BigNum support #34

Open
2 tasks
danleh opened this issue Jun 22, 2022 · 3 comments
Open
2 tasks

Replace Long.js conversion of i64 with JS BigNum support #34

danleh opened this issue Jun 22, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@danleh
Copy link
Owner

danleh commented Jun 22, 2022

See #31 (comment)

Copied from there: remove Long.js dependency completely and use JavaScript BigNums instead, see https://github.com/WebAssembly/proposals/blob/master/finished-proposals.md and https://github.com/WebAssembly/JS-BigInt-integration

  • this wasn't possible back in 2018 because the proposal wasn't finished yet
  • check browser and Node.js compatibility of JS BigNums
  • change low-level hook code to use BigNums instead of Long.js (should be quite easy/mechanical)
@danleh danleh added the enhancement New feature or request label Jun 22, 2022
doehyunbaek added a commit to jakobgetz/wasabi that referenced this issue Nov 8, 2023
@doehyunbaek
Copy link

I think this commit jakobgetz@280947b is quite minimal and easy to review. If you don't mind I'll make a pull request cherry picking this commit.

@danleh
Copy link
Owner Author

danleh commented Jan 6, 2024

That commit looks great, if you could make a PR out of it and it passes tests, we can merge it as-is.

@doehyunbaek
Copy link

I'll work on this in a few weeks. Forgot in a hurry!

doehyunbaek added a commit to jakobgetz/wasabi that referenced this issue Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants