Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove the margins around the buttons #12

Open
Austint30 opened this issue Mar 27, 2017 · 1 comment
Open

Please remove the margins around the buttons #12

Austint30 opened this issue Mar 27, 2017 · 1 comment

Comments

@Austint30
Copy link

Austint30 commented Mar 27, 2017

The whole reason why I wanted window buttons within the top bar is so I could easily close maximized apps just by flinging my mouse to the top-right corner. This extension, for some reason, has a margin above the top of the window buttons which means I have to aim my cursor around the X button to close the app.

Please remove margin above the window buttons. Try using padding or something instead. It would really improve the usability of this extension.

@kennethso168
Copy link

kennethso168 commented Apr 26, 2017

I have a hacky workaround by playing with the CSS of the themes. Go to ~/.local/share/gnome-shell/extensions/[email protected]/themes/<your current theme> and edit the style.css file.
For example, this is the beginning part of the default theme:

/* The box-bin element holds the button-box element which holds each window-button.
 *
 * Control spacing between each button via .button-box.
 */
.box-bin { 
    border-width: 0px;
    padding: 0px;
    margin: 0px;
}

.button-box {
    spacing: 4px;
}

/* The style for each individual window button */
.window-button {
    width: 24px;
    height: 20px;
}

By using the looking class, I find that the .box-bin element's height is 30px, but the .window-button is only 20px tall, so there is some dead space at the top.
A temporary workaround is to simply increase the height of .window-button to 30px.
It's hacky, and I think a more proper solution is to really look into padding or the like. You may also need to adapt it to your own chosen theme. I'm also not sure if it works for other panel sizes, if any (not familiar with gnome).
And I agree this is an important aspect of usability so I wish @danielkza can have a look and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants