Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate operation ID if not present, fixes #201 #213

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

danielgtaylor
Copy link
Owner

If an OpenAPI operation has no operation ID, then generate it using the method+path, converted to kebab casing. For example, GET /users/{user-id}/friendsget-users-user-id-friends. No attempt is made to infer what arguments might mean or whether something is a list vs get.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #213 (04a021c) into main (c47eb00) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   75.76%   75.78%   +0.01%     
==========================================
  Files          26       26              
  Lines        3574     3576       +2     
==========================================
+ Hits         2708     2710       +2     
  Misses        666      666              
  Partials      200      200              
Files Changed Coverage Δ
openapi/openapi.go 88.53% <100.00%> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47eb00...04a021c. Read the comment docs.

@danielgtaylor danielgtaylor merged commit 5db659c into main Aug 4, 2023
6 checks passed
@danielgtaylor danielgtaylor deleted the gen-op-id branch August 4, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant