Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished last bit of the gron outputter implementation #206

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

traviscampbell
Copy link

also updated the test to show it's handling the pesky <, >, & chars.

@traviscampbell traviscampbell mentioned this pull request Jul 30, 2023
Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #206 (a5dcceb) into main (3a541b4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   75.37%   75.41%   +0.04%     
==========================================
  Files          26       26              
  Lines        3513     3519       +6     
==========================================
+ Hits         2648     2654       +6     
  Misses        666      666              
  Partials      199      199              
Files Changed Coverage Δ
cli/content.go 74.28% <100.00%> (+0.56%) ⬆️
cli/gron.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a541b4...a5dcceb. Read the comment docs.

@danielgtaylor danielgtaylor merged commit 1d22b51 into danielgtaylor:main Aug 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants