Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand installation instructions; add Nixpkgs option #204

Conversation

waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Jul 19, 2023

Restish has been added to the Nixpkgs directory with NixOS/nixpkgs#243465 (Thanks @fabaff!) , so now there's an additional method to install it.

This PR expands the installation instructions and includes a mention of Nixpkgs as another way to install Restish.

By the way, we might want to link to Repology for even more installation methods (e.g. there's AUR for ArchLinuz, MacPorts for macOS, pkgsrc for netbsd, Scoop for Windows, and even Termux for Android.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #204 (a8522e5) into main (3a541b4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   75.37%   75.37%           
=======================================
  Files          26       26           
  Lines        3513     3513           
=======================================
  Hits         2648     2648           
  Misses        666      666           
  Partials      199      199           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a541b4...a8522e5. Read the comment docs.

@waldyrious
Copy link
Contributor Author

@danielgtaylor I see you're using a tool called GoReleaser for auto-updating the Homebrew tap. I checked the docs and they seem to also support Nix packages, albeit the instructions seem to be focusing on a custom Nix user repository (NUR). I'm not sure if it still works with the global nixpkgs repository, but I thought I'd mention it :)

@waldyrious
Copy link
Contributor Author

Also, why don't you submit the Homebrew recipe to the core repository? Any reason you prefer to have a custom tap, or was it just more convenient?

Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@danielgtaylor
Copy link
Owner

Also, why don't you submit the Homebrew recipe to the core repository? Any reason you prefer to have a custom tap, or was it just more convenient?

@waldyrious no reason, this was just easy to get started with. I've never submitted anything to the core repo before so it's really just unfamiliarity with the process and how updates get handled there. Feel free to get the ball rolling on that and I can provide support.

@danielgtaylor danielgtaylor merged commit 40a6e65 into danielgtaylor:main Aug 1, 2023
4 checks passed
@waldyrious
Copy link
Contributor Author

Feel free to get the ball rolling on that and I can provide support.

Great! I will do that as soon as I get some free time on my hands :)

@waldyrious waldyrious deleted the expand-installation-instructions branch August 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants