Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle swaps where user pays gas #1233

Open
dcposch opened this issue Jul 25, 2024 · 0 comments
Open

Handle swaps where user pays gas #1233

dcposch opened this issue Jul 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dcposch
Copy link
Member

dcposch commented Jul 25, 2024

Summary

The following transaction should be a single TransferClog: 0xd812...

Instead, we see duplicate transfers:
image

Investigation

The transaction above produces a lot of transfers, including the following four :

  • 0x4D35... sends $0.04 USDC to the PimlicoERC20Paymaster to pay gas limit
  • 0x4D35... sends 210 DEGEN to Uniswap
  • 0x4D35... receives $1.60 USDC from Uniswap
  • 0x4D35... receives $0.02 USDC gas refund rom PimlicoERC20Paymaster

... the extra receives are causing duplicate transfer logs.

Proposed solution

Stopgap: filter our PimlicoERC20Paymaster transfer.
Better: gas accounting as part of Clog spec.

@dcposch dcposch added the bug Something isn't working label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant