Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createrepo version check fails when version is missing #87

Open
ghost opened this issue Sep 29, 2016 · 0 comments
Open

createrepo version check fails when version is missing #87

ghost opened this issue Sep 29, 2016 · 0 comments

Comments

@ghost
Copy link

ghost commented Sep 29, 2016

The version check for createrepo reads:

        ### If version < 0.4.6, then use the old createrepo behaviour
        if not createrepo_version:
            error(0, '%s: Version of createrepo could not be found. Assuming newer than 0.4.6.' % self.dist.nick)
        elif vercmp(createrepo_version, '0.4.6') > 0:
            groupfilename = 'comps.xml'

The message says "assuming newer than 0.4.6", yet it uses the pre-0.4.6 behavior.

I assume this should actually read:

        ### If version < 0.4.6, then use the old createrepo behaviour
        if not createrepo_version:
            error(0, '%s: Version of createrepo could not be found. Assuming newer than 0.4.6.' % self.dist.nick)
            groupfilename = 'comps.xml'
        elif vercmp(createrepo_version, '0.4.6') > 0:
            groupfilename = 'comps.xml'

So that the newer-than-0.4.6 behavior happens both when the version is not defined and when the version is actually greater than 0.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants