Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: allow for usage of rem or px in height and width #355

Open
angel1199410 opened this issue Jul 26, 2023 · 0 comments
Open

Comments

@angel1199410
Copy link

When using height and width in px, there can be issues with accessibility in regards to text-only zoom. Because text zooms and the edges around it do not, edges and nodes rendered with dagree mutate to odd angles and nodes overlap one another.

To recreate the issue:

  • Open Firefox and turn on text zoom only mode
  • Visit reactflow's example using dagre. Open it in the code sandbox. Change the text in the nodes to be longer for more of an effect.
  • Zoom in using browser controls. Note that even though the text gets larger, the edges do not elongate to match.

Allowing for the use of rems (pxValue / 16) will alleviate the text zoom issue and make this library more accessible to users with low vision, or anyone who needs it.

@angel1199410 angel1199410 changed the title Allow for usage of rem or px in height and width Accessibility: allow for usage of rem or px in height and width Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant