Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interactive mode #91

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Added interactive mode #91

wants to merge 27 commits into from

Conversation

ixkael
Copy link

@ixkael ixkael commented Oct 3, 2016

I’ve added a few functions to make possible the interactive modification of the graph once it is rendered. Just set pgm.render(interactive=True). All the demos work as usual. There are a few new classes and functions because I want to drag and drop Nodes and Plates only, with an automatic move of the labels and also the arrows. Finally, one can do print(pgm) to get the new positions of the Nodes/Plates.

@davidwhogg
Copy link
Collaborator

The horror!

Copy link

@drphilmarshall drphilmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any tutorial/user guide documentation on interactive drawing in this branch - what's the plan here? It looks like you are using the matplotlib gui, is that right? Will I be able to make interactive diagrams in a notebook?

@ixkael
Copy link
Author

ixkael commented Oct 5, 2016

All the examples can be run with pgm.render(interactive=True) in the Terminal.

Good point about the notebook - I can add an example / tutorial.

@drphilmarshall
Copy link

drphilmarshall commented Oct 5, 2016 via email

@ixkael
Copy link
Author

ixkael commented Oct 11, 2016

Quick update: I've added a notebook example (just the classic example but in a notebook)

Get more information at: `daft-pgm.org <http://daft-pgm.org>`_
Get more information at `daft-pgm.org <http://daft-pgm.org>`_

Try making some PGMs with the `example notebooks <http://mybinder.org:/repo/drphilmarshall/daft>`_

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ixkael If you know this is going to work, I guess we should change all these drphilmarshall URLs to dfm ones instead...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ixkael I still see drphilmarshall URLs... but you must be so close to that Kwak by now! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants