Port to windows #31

0x7f · 2017-08-13T18:55:22Z

This patch makes httpp compile on Windows 10 with Visual Studio 2017 Community edition (VC 14.0).

The according commonpp patch can be found here daedric/commonpp#7. The same issue about static linking of TBB and HWLOC applies to this as well.

Visual Studio likes plain old stuff ;)

0x7f · 2017-08-13T18:55:29Z

Many tests are failing still. Working on it.

1>------ Build started: Project: RUN_TESTS, Configuration: Debug x64 ------
1>setlocal
1>C:\Users\max\opt\cmake-3.8.2-win64-x64\bin\ctest.exe --force-new-ctest-process -C Debug
1>if %errorlevel% neq 0 goto :cmEnd
1>:cmEnd
1>endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone
1>:cmErrorLevel
1>exit /b %1
1>:cmDone
1>if %errorlevel% neq 0 goto :VCEnd
1>:VCEnd
1>Test project C:/Users/max/Development/httpp/build
1>      Start  1: core_options
1> 1/29 Test  #1: core_options .....................   Passed    0.04 sec
1>      Start  2: core_string_stringify
1> 2/29 Test  #2: core_string_stringify ............   Passed    0.03 sec
1>      Start  3: core_string_encode
1> 3/29 Test  #3: core_string_encode ...............   Passed    0.03 sec
1>      Start  4: metric_reservoir_edr
1> 4/29 Test  #4: metric_reservoir_edr .............   Passed    0.27 sec
1>      Start  5: net_http_encode-decode
1> 5/29 Test  #5: net_http_encode-decode ...........   Passed    0.03 sec
1>      Start  6: net_http_request
1> 6/29 Test  #6: net_http_request .................   Passed    0.04 sec
1>      Start  7: net_http_response
1> 7/29 Test  #7: net_http_response ................   Passed    0.04 sec
1>      Start  8: post_content
1> 8/29 Test  #8: post_content .....................***Exception: Other  0.03 sec
1>      Start  9: header
1> 9/29 Test  #9: header ...........................***Exception: Other  0.01 sec
1>      Start 10: error
1>10/29 Test #10 : error ............................***Exception: Other  0.02 sec
1>      Start 11: query
1>11/29 Test #11: query ............................***Exception: Other  0.01 sec
1>      Start 12: post_data
1>12/29 Test #12: post_data ........................***Exception: Other  0.01 sec
1>      Start 13: follow_redirect
1>13/29 Test #13: follow_redirect ..................***Exception: Other  0.01 sec
1>      Start 14: continue
1>14/29 Test #14: continue .........................***Exception: Other  0.01 sec
1>      Start 15: completion_handler
1>15/29 Test #15: completion_handler ...............***Exception: Other  0.01 sec
1>      Start 16: google
1>16/29 Test #16: google ...........................***Exception: Other  0.01 sec
1>      Start 17: cancel_async_operation
1>17/29 Test #17: cancel_async_operation ...........***Exception: Other  0.01 sec
1>      Start 18: delete
1>18/29 Test #18: delete ...........................***Exception: Other  0.01 sec
1>      Start 19: file
1>19/29 Test #19: file .............................***Exception: Other  0.01 sec
1>      Start 20: query
1>20/29 Test #20: query ............................***Exception: Other  0.01 sec
1>      Start 21: parser_streambuf
1>21/29 Test #21: parser_streambuf .................   Passed    0.03 sec
1>      Start 22: headers
1>22/29 Test #22: headers ..........................***Exception: Other  0.01 sec
1>      Start 23: body
1>23/29 Test #23: body .............................***Exception: Other  0.01 sec
1>      Start 24: start_stop_server
1>24/29 Test #24: start_stop_server ................***Exception: Other  0.01 sec
1>      Start 25: chunked_encoding
1>25/29 Test #25: chunked_encoding .................***Exception: Other  0.01 sec
1>      Start 26: pipeline
1>26/29 Test #26: pipeline .........................***Exception: Other  0.01 sec
1>      Start 27: vector
1>27/29 Test #27: vector ...........................   Passed    0.03 sec
1>      Start 28: decode
1>28/29 Test #28: decode ...........................   Passed    0.03 sec
1>      Start 29: sorted_vector
1>29/29 Test #29: sorted_vector ....................   Passed    0.03 sec
1>
1>38% tests passed, 18 tests failed out of 29
1>
1>Total Test time (real) =   0.88 sec
1>
1>The following tests FAILED:
1>	  8 - post_content (OTHER_FAULT)
1>	  9 - header (OTHER_FAULT)
1>	 10 - error (OTHER_FAULT)
1>	 11 - query (OTHER_FAULT)
1>	 12 - post_data (OTHER_FAULT)
1>	 13 - follow_redirect (OTHER_FAULT)
1>	 14 - continue (OTHER_FAULT)
1>	 15 - completion_handler (OTHER_FAULT)
1>	 16 - google (OTHER_FAULT)
1>	 17 - cancel_async_operation (OTHER_FAULT)
1>	 18 - delete (OTHER_FAULT)
1>	 19 - file (OTHER_FAULT)
1>	 20 - query (OTHER_FAULT)
1>	 22 - headers (OTHER_FAULT)
1>	 23 - body (OTHER_FAULT)
1>	 24 - start_stop_server (OTHER_FAULT)
1>	 25 - chunked_encoding (OTHER_FAULT)
1>	 26 - pipeline (OTHER_FAULT)
1>Errors while running CTest
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: The command "setlocal
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: C:\Users\max\opt\cmake-3.8.2-win64-x64\bin\ctest.exe --force-new-ctest-process -C Debug
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: if %errorlevel% neq 0 goto :cmEnd
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: :cmEnd
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: :cmErrorLevel
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: exit /b %1
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: :cmDone
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: if %errorlevel% neq 0 goto :VCEnd
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(133,5): error MSB3073: :VCEnd" exited with code 8.
1>Done building project "RUN_TESTS.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========

0x7f · 2017-08-13T18:56:30Z

include/httpp/utils/SortedVectorKP.hpp

@@ -31,7 +31,13 @@ struct case_insensitive
        }
        else if (left.size() == right.size())
        {
+#ifdef WIN32
+# define strncasecmp(x, y, z) _strnicmp(x, y, z)


@daedric what about introducing a utils header which includes this define or is it ok to have it multiple times all over the place?

0x7f · 2017-08-13T19:16:56Z

The Ragel parser seems to be the problem. When using the stream parser, only 3 tests fail:

For Test_Server_body i get this error:

unknown location(0): fatal error: in "body_too_big": class boost::exception_detail::clone_impl<struct boost::exception_detail::error_info_injector<class boost::system::system_error> >: read_until: An established connection was aborted by the software in your host machine
C:\Users\max\Development\httpp\tests\server\body.cpp(235): last checkpoint: "body_too_big" entry.

Test_client_error just hangs at :

[2017-08-13 21:12:10.500570] [0x00004008] [info]    CheckHandles

And Test_client_post_data segfaults at CheckHandles.

Will continue investigating later. At least the examples are working :)

0x7f · 2017-08-13T19:21:28Z

And for completeness, list of dynamically linked DLLs according to depends:

daedric · 2017-08-16T08:35:54Z

Hi @0x7f,
Maybe some exceptions have different code on windows than on unixes-like systems.
I'll have a look !

Thanks a lot !

0x7f added 5 commits August 13, 2017 19:08

Require at least Windows 7

313e8bd

Make sure TBB and HWLOC paths are included

31f0b5e

Do not use notkeyword but use plain old !

2fc9098

Visual Studio likes plain old stuff ;)

Port string functions to Windows

95cd1c2

(Revert me: use 0x7f/commonpp#port-to-windows)

5c45947

0x7f commented Aug 13, 2017

View reviewed changes

0x7f mentioned this pull request Aug 13, 2017

cant use vcpkg download it? #30

Closed

daedric force-pushed the master branch from d87417e to 22a8df8 Compare July 13, 2023 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port to windows #31

Port to windows #31

0x7f commented Aug 13, 2017

0x7f commented Aug 13, 2017

0x7f Aug 13, 2017

0x7f commented Aug 13, 2017

0x7f commented Aug 13, 2017

daedric commented Aug 16, 2017

Port to windows #31

Are you sure you want to change the base?

Port to windows #31

Conversation

0x7f commented Aug 13, 2017

0x7f commented Aug 13, 2017

0x7f Aug 13, 2017

Choose a reason for hiding this comment

0x7f commented Aug 13, 2017

0x7f commented Aug 13, 2017

daedric commented Aug 16, 2017