Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate how the accessibility service closes the last app / SD Maid when running via scheduler #1322

Open
d4rken opened this issue Jul 17, 2024 · 1 comment
Labels
Automation Accessibility service related c: AppCleaner c: Scheduler enhancement New feature, request, improvement or optimization

Comments

@d4rken
Copy link
Member

d4rken commented Jul 17, 2024

As of #1320 we now use single back button presses on Android TV, and press the home button on non-TV devices.
Because pressing the home button can change the last open-app, we could reevaluate using the back button. See #1240

Possible improvements:

  • Make the amount of back button presses variable and depend on the ROMSpec used by the AppCleaner
  • Check if the back button press was successful, if it failed, fall back to the home button routine
@d4rken d4rken added enhancement New feature, request, improvement or optimization c: AppCleaner c: Scheduler Automation Accessibility service related labels Jul 17, 2024
@MarkyMarkDE
Copy link

MarkyMarkDE commented Jul 18, 2024

Thanks for adding it.
On my Pixel7 with Android 14 this push back method works same as on AndroidTV, maybe we can do in a first step AndroidTV and Pixel Devices are handled same? If we know more details which Android Version or which ROM don't work with that, we can thinking about different / more detailed rules or something.

You can also add a comment in the code, that the push back method properly work on:
Pixel7 with Android 14 and Patches of July 24
AndroidTV with Android 11 and Patches April 24 on waipu.tv 4 k Stick and also on your Testsystem xx

FYI: I'm pretty sure, that something other has changed between 0.23.0 and 0.24.* what breaks something.

You have removed the push back method in 1.0.1 right? But the main problem started on 0.24.0+ at the first time ...
In 0.23.0 SDMaid is a 'hidden and invisible background process' and on 0.24.* it becomes visible, but why?
It's hard to explain, maybe you check 0.23.0 and also 0.24.0 to see the finish process and see what I mean.

If you need, I will check 0.23.1, 0.23.2 and 0.23.3, then I'm able to say 'something in xx cause the problem' so you have it maybe easier to find the reason for the break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Accessibility service related c: AppCleaner c: Scheduler enhancement New feature, request, improvement or optimization
Projects
None yet
Development

No branches or pull requests

2 participants