Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intertechno: Fix head and tail formatter #30

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

jdemel
Copy link
Contributor

@jdemel jdemel commented Jan 28, 2024

The head and tail formatter for the Intertechno gateway were missing a trailing "0". After adding these, the ITGW-433 can operate a CMR1000.

The corresponding work can be found here:
https://www.instructables.com/Intertechno-LAN-Gateway-ITGW-433-and-OpenHAB/

Fixes #29

@d-Rickyy-b
Copy link
Owner

d-Rickyy-b commented Jan 28, 2024

Thank you very much for spotting and fixing the issue. I appreciate your work. May I ask you to add fixes to the test cases too?

Specifically it should be only one broken test case:

self.assertEqual("0,0,2345,111,557,91919,A,SIGNAL-A,B,B,A-SIGNAL,C,1,432", payload)

This should rather be

self.assertEqual("0,0,2345,111,557,91919,0,A,SIGNAL-A,B,B,A-SIGNAL,C,1,432,0", payload)

I'll merge when the tests are green.

The head and tail formatter for the Intertechno gateway were missing a
trailing "0". After adding these, the ITGW-433 can operate a CMR1000.

The corresponding work can be found here:
https://www.instructables.com/Intertechno-LAN-Gateway-ITGW-433-and-OpenHAB/
@jdemel
Copy link
Contributor Author

jdemel commented Jan 29, 2024

I managed to push the updated commit without the changes in the tests file. This should be fixed now. Also, I'd expect the tests to complete successfully now.

@d-Rickyy-b
Copy link
Owner

Thank you for the update. The tests went through, sadly there's an issue with the coverage run. I guess the GITHUB_TOKEN is not available on third party PRs? Anyway, still fine to merge :)

@d-Rickyy-b d-Rickyy-b merged commit d7b55ed into d-Rickyy-b:master Jan 29, 2024
0 of 3 checks passed
@jdemel
Copy link
Contributor Author

jdemel commented Jan 29, 2024

Thanks for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ITGW-433 requires a slightly updated head and tail formatter
2 participants