From 9d965da1869e1e2ab52e52332e2aae320cdd6a4e Mon Sep 17 00:00:00 2001
From: Robert Stepanek <rsto@fastmailteam.com>
Date: Thu, 17 Aug 2023 09:43:41 +0200
Subject: [PATCH] jmap_mail: do not dereference NULL pointer in Email/parse

Fixes #4574

Thanks to @dilyanpalauzov

Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
---
 .../JMAPEmail/email_parse_inmemory_blob       | 45 +++++++++++++++++++
 imap/jmap_mail.c                              |  2 +-
 2 files changed, 46 insertions(+), 1 deletion(-)
 create mode 100644 cassandane/tiny-tests/JMAPEmail/email_parse_inmemory_blob

diff --git a/cassandane/tiny-tests/JMAPEmail/email_parse_inmemory_blob b/cassandane/tiny-tests/JMAPEmail/email_parse_inmemory_blob
new file mode 100644
index 0000000000..792e95a395
--- /dev/null
+++ b/cassandane/tiny-tests/JMAPEmail/email_parse_inmemory_blob
@@ -0,0 +1,45 @@
+#!perl
+use Cassandane::Tiny;
+
+sub test_email_parse_inmemory_blob
+    :min_version_3_9 :needs_component_jmap
+{
+    my ($self) = @_;
+    my $jmap = $self->{jmap};
+
+    # XXX: replace with the upstream one once RFC 9404 is finished
+    $jmap->AddUsing('https://cyrusimap.org/ns/jmap/blob');
+
+    my $mimeMsg = <<'EOF';
+From: <from@local>
+To: to@local
+Bcc: bcc@local
+Subject: test
+Date: Mon, 13 Apr 2020 15:34:03 +0200
+MIME-Version: 1.0
+Content-Type: text/plain
+
+hello
+EOF
+    $mimeMsg =~ s/\r?\n/\r\n/gs;
+
+    # XXX: can't use a result reference in array
+    my $blobId = 'G67501cd2e1eaaf65d25e6f3b49554d2193f06ee8';
+
+    $res = $jmap->CallMethods([
+        ['Blob/upload', {
+            create => {
+                b1 => {
+                    data => [{'data:asText' => $mimeMsg}]
+                },
+            },
+        }, 'R1'],
+        ['Email/parse', {
+            blobIds => [$blobId],
+            properties => ['subject', 'bodyStructure'],
+        }, 'R2'],
+    ]);
+    $self->assert_str_equals('Blob/upload', $res->[0][0]);
+    $self->assert_not_null($res->[0][1]{created}{b1}{id});
+    $self->assert_str_equals('test', $res->[1][1]{parsed}{$blobId}{subject});
+}
diff --git a/imap/jmap_mail.c b/imap/jmap_mail.c
index bbd905c714..2cb67097b9 100644
--- a/imap/jmap_mail.c
+++ b/imap/jmap_mail.c
@@ -8444,7 +8444,7 @@ static int jmap_email_parse(jmap_req_t *req)
 
         struct buf *inmem = hash_lookup(blobid, req->inmemory_blobs);
         if (inmem) {
-            r = _email_from_buf(req, &getargs, inmem, part->encoding, &email);
+            r = _email_from_buf(req, &getargs, inmem, NULL, &email);
             if (r) {
                 syslog(LOG_ERR, "jmap: Email/parse(%s): %s", blobid, error_message(r));
             }