Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pnpm v9 and above support #495

Closed
MikeMcC399 opened this issue Nov 11, 2024 · 1 comment
Closed

Missing pnpm v9 and above support #495

MikeMcC399 opened this issue Nov 11, 2024 · 1 comment
Labels
type: bug 🐛 Something isn't working

Comments

@MikeMcC399
Copy link
Collaborator

Current behavior

Running Cypress pnpm projects only works out-of-the-box for pnpm v8 lockfiles. Attempting to run with a pnpm v9 lockfile causes a fatal error message:

 WARN  Ignoring not compatible lockfile at /home/circleci/project/pnpm-lock.yaml
 ERR_PNPM_NO_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is present

Desired behavior

The Cypress CircleCI orb should support selection and use of any pnpm version v8, v9 and future versions above. pnpm is sensitive to the version of lockfile used.

See also circleci/node and install-pnpm - version parameter.

Test code to reproduce

Run the following workflow against a project with a pnpm lockfile pnpm-lock.yaml created with pnpm v8, then with v9:

using Cypress CircleCI Orb:

version: 2.1
orbs:
cypress: cypress-io/[email protected]
workflows:
use-my-orb:
    jobs:
    - cypress/run:
        package-manager: "pnpm"
        start-command: "pnpm start"
        install-command: "pnpm install --frozen-lockfile"

Results

pnpm version \ Orb version 3.4.0 lockfileVersion
latest-8 (v8.15.9) Pass 6.0
latest-9 (v9.12.3) Fail (1) 9.0

(1) "WARN  Ignoring not compatible lockfile at /home/circleci/project/pnpm-lock.yaml"

The executor being used is cimg/node:18.16.1-browsers, which has [email protected] pre-installed.

$ docker run --rm --entrypoint sh cimg/node:18.16.1-browsers -c 'pnpm -v'
8.6.3
@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Nov 13, 2024

This issue is no longer reproducible with cypress-io/[email protected]

The Orb is now installing the latest version of pnpm by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant