Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate rose configs against metadata on installation #23

Open
oliver-sanders opened this issue Jan 15, 2021 · 0 comments
Open

validate rose configs against metadata on installation #23

oliver-sanders opened this issue Jan 15, 2021 · 0 comments
Labels
question Flag this as a question for the next Cylc project meeting.
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jan 15, 2021

Issue transferred from metomi/rose#1908

On install run validator macros against:

  1. The suite config?
  • And each optional suite config individually?
  1. The app configs?
  • And each optional app config individually?

From the copy in:

a. The source dir (pre-install)?

  • Can block installation upon encountering invalid configs.
  • Cannot validate any apps that are installed using Rose file installation.

b. The run dir (post-install)?

  • Can't block installation (because it has already happened).
  • Can quibble, log warnings and change the exit status of the install command.

When:

i. By default (with a CLI flag to opt-out)?

  • Could make installation slow.

ii. When a CLI flag is used (opt in)?

  • Would never be used.

iii. According to the config?

  • E.G. Allow the rose-suite.conf to configure apps to exclude?
  • E.G. Support the rose macro --no-warn=WARNING_TYPE opt?

Context:

  • Validating the suite config should be quick.
  • However, the apps may take a while.
  • Not all opt configs are necessarily valid in of themselves.
    • Though it can be contested that this is poor design.
    • Note: some opt confs may be designed to be used in combination with others.
  • The proportion of real world suites that pass rose macro is likely quite low.
@oliver-sanders oliver-sanders added this to the later milestone Jan 15, 2021
@oliver-sanders oliver-sanders added the question Flag this as a question for the next Cylc project meeting. label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Flag this as a question for the next Cylc project meeting.
Projects
None yet
Development

No branches or pull requests

1 participant