Update github action definition #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would really like to see the workflow executed here... investigating. |
|
@cweiske I think this is good to go from my side now. |
|
Thank you so much for your work! |
|
There is more in the queue, but I wasn't sure about feedback. I'll try to make small steps. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted the codestyle part because that should be the same for all PHP versions. Also I added validating the composer.json there because why not.
The remaining test is now renamed to "phpunit" for a nicer name feeling in the Github UI.
It just seems like this script needs activation in your repository... in my fork, I started by adding a very generic template using the UI function, and magically... the original "master" version already seems to work, although it complains about outdated action scripts.
Closes #221