feat: add @nodevu/fetchindex #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tierney Cyren <[email protected]>
|
worth noting, this API will probably immediately change as I spin out |
Signed-off-by: Tierney Cyren <[email protected]>
Signed-off-by: Tierney Cyren <[email protected]>
Signed-off-by: Tierney Cyren <[email protected]>
|
The package doesn't seem to be published, ftr |
ljharb
reviewed
Nov 12, 2024
| "luxon": "^3.5.0", | ||
| "undici": "^6.20.1" | ||
| } | ||
| } |
There was a problem hiding this comment.
it'd be great to add engines.node here as well :-)
|
Sorry this got lost in my notifications, but consider this an after merge 👍 EDIT: I miss tabs in projects. This made me happy today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR abstracts the
util/prod/version.jsfile from@nodevu/coreinto a new package,@nodevu/fetchindex. This is the result of a discussion with @ljharb and @wesleytodd at the Node.js Collaborator Summit in Dublin, Ireland.