Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing 'v's in a few spots. #28

Open
bnb opened this issue Jan 3, 2023 · 0 comments
Open

fix missing 'v's in a few spots. #28

bnb opened this issue Jan 3, 2023 · 0 comments

Comments

@bnb
Copy link
Member

bnb commented Jan 3, 2023

there are a few places where data is unfortunately inconsistent. Specifically, we're sometimes returning semver version with a "v" while other times we're not. You can see where this bubbles up in the ranges tests. Ideally, this will be solved in core as well, though I'm not yet sure if it's actually an issue there.

Regardless, anywhere we return a semver version we should start it with a "v" for the sake of consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant