From 90b5c9d2a744586701af5e0cb359a2714aa92b09 Mon Sep 17 00:00:00 2001
From: Marcel van Lohuizen <mpvl@gmail.com>
Date: Mon, 7 Oct 2024 13:22:17 +0200
Subject: [PATCH] all: annotate priority of bugs marked by TODO_V3

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idca483416f7f1d59d925e7df39875f2db2d4e124
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1202263
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Matthew Sackman <matthew@cue.works>
---
 cue/types_test.go                       | 16 ++++++++--------
 internal/core/validate/validate_test.go |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/cue/types_test.go b/cue/types_test.go
index be410605489..454555dfa74 100644
--- a/cue/types_test.go
+++ b/cue/types_test.go
@@ -139,7 +139,7 @@ func TestAPI(t *testing.T) {
 			continue
 		}
 		cuetdtest.FullMatrix.Run(t, "", func(t *testing.T, m *cuetdtest.M) {
-			m.TODO_V3(t)
+			m.TODO_V3(t) // P1: faulty closedness
 
 			ctx := m.CueContext()
 
@@ -1873,7 +1873,7 @@ func TestTemplate(t *testing.T) {
 	for _, tc := range testCases {
 		cuetdtest.FullMatrix.Run(t, "", func(t *testing.T, m *cuetdtest.M) {
 			if tc.skip {
-				m.TODO_V3(t)
+				m.TODO_V3(t) // P2: reordering
 			}
 
 			v := getValue(m, tc.value)
@@ -1937,7 +1937,7 @@ func TestElem(t *testing.T) {
 	for _, tc := range testCases {
 		cuetdtest.FullMatrix.Run(t, "", func(t *testing.T, m *cuetdtest.M) {
 			if tc.skip {
-				m.TODO_V3(t)
+				m.TODO_V3(t) // P2: reordering
 			}
 
 			v := getValue(m, tc.value)
@@ -2489,7 +2489,7 @@ func TestValidate(t *testing.T) {
 	for _, tc := range testCases {
 		cuetdtest.FullMatrix.Run(t, tc.desc, func(t *testing.T, m *cuetdtest.M) {
 			if tc.skip {
-				m.TODO_V3(t)
+				m.TODO_V3(t) // P1: wrong results
 			}
 
 			ctx := m.CueContext()
@@ -2760,7 +2760,7 @@ Another Foo.
 		}}
 		for _, tc := range testCases {
 			if tc.skip {
-				m.TODO_V3(t)
+				m.TODO_V3(t) // P2: reordering
 			}
 			t.Run("field:"+tc.path, func(t *testing.T) {
 				v := tc.val.Lookup(strings.Split(tc.path, " ")...)
@@ -2959,7 +2959,7 @@ func TestMarshalJSON(t *testing.T) {
 	}}
 	for i, tc := range testCases {
 		cuetdtest.FullMatrix.Run(t, fmt.Sprintf("%d/%v", i, tc.value), func(t *testing.T, m *cuetdtest.M) {
-			m.TODO_V3(t)
+			m.TODO_V3(t) // P1: wrong output
 
 			val := getValue(m, tc.value)
 			b, err := val.MarshalJSON()
@@ -3040,7 +3040,7 @@ func TestWalk(t *testing.T) {
 	}}
 	for i, tc := range testCases {
 		cuetdtest.FullMatrix.Run(t, fmt.Sprintf("%d/%v", i, tc.value), func(t *testing.T, m *cuetdtest.M) {
-			m.TODO_V3(t)
+			m.TODO_V3(t) // P1: missing undefined field
 
 			val := getValue(m, tc.value)
 			buf := []byte{}
@@ -3260,7 +3260,7 @@ a: x: y: z: "x"`,
 	for _, tc := range testCases {
 		cuetdtest.FullMatrix.Run(t, "", func(t *testing.T, m *cuetdtest.M) {
 			if tc.skip {
-				m.TODO_V3(t)
+				m.TODO_V3(t) // P3: different position
 			}
 
 			c := m.CueContext()
diff --git a/internal/core/validate/validate_test.go b/internal/core/validate/validate_test.go
index 19430b4f57a..1b60cc32dba 100644
--- a/internal/core/validate/validate_test.go
+++ b/internal/core/validate/validate_test.go
@@ -245,7 +245,7 @@ y: conflicting values 4 and 2:
 
 	cuetdtest.Run(t, testCases, func(t *cuetdtest.T, tc *testCase) {
 		if tc.todo_v3 {
-			t.M.TODO_V3(t)
+			t.M.TODO_V3(t) // P1: cycle error missing? Other error.
 		}
 		r := t.M.Runtime()
 		ctx := eval.NewContext(r, nil)