Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubed-specific diagnostics to record #3

Open
3 of 4 tasks
TomNicholas opened this issue Mar 1, 2024 · 6 comments
Open
3 of 4 tasks

Cubed-specific diagnostics to record #3

TomNicholas opened this issue Mar 1, 2024 · 6 comments

Comments

@TomNicholas
Copy link
Member

TomNicholas commented Mar 1, 2024

Some ideas:

All could be added later though. I think duration is what we're interested in most.

Originally posted by @tomwhite in #1 (comment)

@TomNicholas
Copy link
Member Author

Recording the duration is done via a context manager - perhaps the others will need to be handled by passing callbacks to cubed instead.

@TomNicholas
Copy link
Member Author

Can we just use the HistoryCallback every time, then read the results from the csv file that callback writes to?

@tomwhite
Copy link
Member

tomwhite commented Mar 4, 2024

Can we just use the HistoryCallback every time, then read the results from the csv file that callback writes to?

Or get the values directly from the events list stored on the HistoryCallback object.

@TomNicholas
Copy link
Member Author

Or get the values directly from the events list stored on the HistoryCallback object.

In that case what's the best way to get access to the history = HistoryCallback() object from within the wrapping benchmark context manager?

@TomNicholas
Copy link
Member Author

Oh maybe the benchmark context manager should accept an argument (like how in coiled-benchmarks the benchmark_all context manager accepts a client argument).

@tomwhite
Copy link
Member

It would also be useful to record number of backup tasks run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants