Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type: Resolve plugins additional properties #1464

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hosseinmd
Copy link
Member

Corresponding issue (if exists):

What would you like to add/fix?

In this PR I added a generic type for Styles in jss for additional properties.
Export compose and extend packages added properties, merged them in default plugin package

Todo

  • Add test that verifies the modified behavior
  • Add documentation if it changes public API

@hosseinmd hosseinmd requested a review from kof as a code owner March 11, 2021 09:25
@kof
Copy link
Member

kof commented Mar 11, 2021

  • we should def. have ts tests for those things

@kof kof added the typescript label Mar 11, 2021
@kof
Copy link
Member

kof commented Mar 14, 2021

we got merge conflicts

@kof
Copy link
Member

kof commented Jun 27, 2021

Can someone from @cssinjs/typescript team please give it a look?

@kof kof requested a review from a team June 27, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants