Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy printing logic #38

Open
dmalan opened this issue Oct 4, 2017 · 1 comment
Open

tidy printing logic #38

dmalan opened this issue Oct 4, 2017 · 1 comment
Assignees
@cmlsharp
Labels
enhancement

Comments

@dmalan
Copy link
Member

dmalan commented Oct 4, 2017

https://github.com/cs50/style50/blob/develop/style50/style50.py#L95-L124

Goal is to generate outputs below. Note deliberate blank lines for readability. Code has just gotten rather untidy.

screen shot 2017-10-04 at 10 23 29 am

screen shot 2017-10-04 at 10 23 18 am

screen shot 2017-10-04 at 10 23 03 am

screen shot 2017-10-04 at 10 22 49 am
@dmalan dmalan mentioned this issue Oct 4, 2017
Merged
@cmlsharp
Copy link
Contributor

Definitely agree that the logic could use improvement. Unfortunately there are quite a few edge case to consider, but I'll work on collapsing as many of the conditionals as possible. In the meantime, I think we should merge #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmlsharp cmlsharp

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmalan @cmlsharp