Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo #2597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

valeriypushkar
Copy link

Small typo fix in _process function.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Valery Pushkar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@elopez
Copy link
Member

elopez commented Oct 30, 2024

Hi! thanks for the PR. I suspect this might have been done on purpose to keep mypy happy and it might not be a typo. We don't seem to be running mypy on CI these days though 🤔

@valeriypushkar
Copy link
Author

valeriypushkar commented Oct 30, 2024

Hi @elopez ! I've just run mypy locally on the whole project. Mypy found some issues but not in the fixed code lines. Mypy version is 1.13.0 (compiled: yes).
The issues in main.py file are:

__main__.py:17: error: Cannot find implementation or library stub for module named "crytic_compile"  [import-not-found]
__main__.py:18: error: Cannot find implementation or library stub for module named "crytic_compile.platform.standard"  [import-not-found]
__main__.py:19: error: Cannot find implementation or library stub for module named "crytic_compile.platform.etherscan"  [import-not-found]
__main__.py:253: error: Incompatible return value type (got "set[type[AbstractDetector]]", expected "list[type[AbstractDetector]]")  [return-value]
__main__.py:885: error: Function "output_to_sarif" could always be true in boolean context  [truthy-function]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants