Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: make container multi-platform #1136

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

elopez
Copy link
Member

@elopez elopez commented Nov 1, 2023

This enables aarch64 builds for our Docker container image. These can then be used on e.g. M1 Macs to get good performance. It also makes the echidna binary static with musl -- previously it was static with glibc, which might be problematic as shown on #962 if the binary is re-used outside this container (I believe using it inside the container should not cause issues as the glibc version matches between binary and runtime environment)

Caveat: The container is built on an x86 runner using emulation, so the build is somewhat slow (~4h total build time).

@elopez
Copy link
Member Author

elopez commented Nov 1, 2023

This would allow us to then include the aarch64 binary in eth-security-toolbox.

@elopez elopez changed the base branch from m1-builds-github to master January 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant