Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'+Create Wallet' Button creates pitfall (Multisig) #281

Open
pvig0q1s opened this issue Aug 21, 2024 · 0 comments
Open

'+Create Wallet' Button creates pitfall (Multisig) #281

pvig0q1s opened this issue Aug 21, 2024 · 0 comments

Comments

@pvig0q1s
Copy link

pvig0q1s commented Aug 21, 2024

On the default screen for exporting a Multisig key there is a '+Create wallet' button which will lead users to create a single sig wallet (p2wpkh) using default multisig derivation (m/48'/1'/0'/2'). The button is missleading in this place since users might press the button, go to the Wallets App and export information to the co-ordinator from here (and end up with a wpkh key in their co-ordinator software).

To reproduce:

  • Main screen > Master public keys > Multisig
    "Your master public key" screen: The information for canonical xpub as well as SLIP-132 shows pubkey information adhering to multisig defaults
  • '+Create wallet' > Native Segwit > "Name your Wallet" > Done
    "Add wallet" screen: toggling to SLIP-132 shows vpub notation (lower case v) and does therefore not match the defaults for a multisig P2WSH key (Vpub)
  • 'Confirm' (Wallet propagates to Wallets menu).

//edit: I'm on testnet, but same goes for other networks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant