Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated REST APIs for Bybit spot market services from v3 to v5 #468

Merged
merged 2 commits into from
May 17, 2024

Conversation

obergaba
Copy link
Contributor

The 2 commented target links were not used.

Is it a good idea to 'hardcode' the parameter "category=spot" inside the convertRequestForRest function? I believe it's intrinsic that when the user specifies the exchange as 'bybit' in the request constructor in the main, rather than 'bybit-derivatives', their intention is to operate within the spot market. Previously, this wasn't an issue because we had different endpoints for spot and derivatives.

Now for every request the user needs to remember to add it like this in the main:

  Request request(Request::Operation::GET_RECENT_TRADES, "bybit", "BTCUSDT");
  request.appendParam({
      {"INSTRUMENT_TYPE", "spot"},  <---
      {"other param", "other param"},
      ...
  });

@obergaba obergaba changed the title Updated REST APIs for Bybit market services from v3 to v5 Updated REST APIs for Bybit spot market services from v3 to v5 May 16, 2024
@chassis-community
Copy link
Contributor

Is it a good idea to 'hardcode' the parameter "category=spot" inside the convertRequestForRest function? I think it is OK.

@chassis-community chassis-community merged commit da349f2 into crypto-chassis:develop May 17, 2024
1 check passed
Copy link

🎉 This PR is included in version 6.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants