fix: Prevent out-of-bounds access in ceilSearch function #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that when subscribing to an instrument and specifying the depth of the order book that you would like to be updated on, the calculateMarketDepthAllowedByExchange function gets called with a vector of the actually possible depths the exchange offers. This function then utilizes the ceilSearch function to determine the closest greatest market depth allowed by the exchange to the depthWanted.
In the current implementation, there is a potential issue where the function may iterate beyond the last element of the vector if the desired market depth exceeds the greatest market depth offered by the exchange.
Will leave screenshots as an attachment.
**
**