Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalization of EllipticCurvePoints #78

Open
rheitjoh opened this issue Apr 7, 2021 · 0 comments
Open

Fix normalization of EllipticCurvePoints #78

rheitjoh opened this issue Apr 7, 2021 · 0 comments
Labels
Gitlab Old issue moved over from Gitlab repository

Comments

@rheitjoh
Copy link
Member

rheitjoh commented Apr 7, 2021

(This issue has been imported from the Gitlab repository because it seems to not have been addressed yet)

Original Text (Issue 211)

Currently, there is a method normalize() that returns a new EllipticCurvePoint. I suggest instead to add a normalized version to the existing point or just to replace the point values with normalized ones (which, I think, is never bad).
Furthermore, `normalize() probably shouldn't be public. The user of such points doesn't care. protected should suffice.

Comment by Jan Bobolz

Also: let isNormalized() be protected

@rheitjoh rheitjoh added the Gitlab Old issue moved over from Gitlab repository label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitlab Old issue moved over from Gitlab repository
Projects
None yet
Development

No branches or pull requests

1 participant