Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unbanning from the Ban Effect does not work #2809

Open
1 task done
Vixenary opened this issue Sep 13, 2024 · 0 comments
Open
1 task done

[Bug] Unbanning from the Ban Effect does not work #2809

Vixenary opened this issue Sep 13, 2024 · 0 comments
Labels
Bug A defect in the app Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release

Comments

@Vixenary
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Unbanning users from the "Ban" Effect results in an unhandled promise.

Expected Behavior

Unbanning users from the "Ban" Effect should result in either, a successful unban if the specified user is banned, or a silent (success/failure) if the user is not banned.

Steps To Reproduce

  1. Create a new preset Effect list.
  2. Add the "Ban" Effect and specify the ban action.
  3. Specify a random user to ban.
  4. Add another "Ban" Effect and specify the unban action.
  5. Unban the same user.
  6. Run the preset Effect list.

Version

5.63.2

What operating system are you using Firebot on?

Windows 11

Relevant log output

[2024-09-13 16:24:49.0540] - error: [v5.63.2] Unhandled promise rejection 
{
  message: 'twitchApi.moderation.unban is not a function',
  stack: 'TypeError: twitchApi.moderation.unban is not a function\n' +
    '    at Object.onTriggerEvent (C:\\Users\\vixen\\AppData\\Local\\firebotv5\\app-5.63.2\\resources\\app.asar\\build\\backend\\effects\\builtin\\moderator-ban.js:69:59)\n' +
    '    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n' +
    '    at async C:\\Users\\vixen\\AppData\\Local\\firebotv5\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:89:24'
}

Contact Details (Optional)

Vixenary

@Vixenary Vixenary added the Bug A defect in the app label Sep 13, 2024
@Vixenary Vixenary changed the title [Bug] [Bug] Unbanning from the Ban Effect does not work Sep 13, 2024
@CKY- CKY- added Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review. labels Sep 15, 2024
@CaveMobster CaveMobster added Release Pending Issue has been resolved and is waiting to be packaged as part of a release and removed Ready For Review Issue has a PR opened and is undergoing dev review. labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release
Projects
Status: Release Pending
Status: Release Pending
Development

No branches or pull requests

3 participants