Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Currency Bonus values don't work for Twitch roles (T1, T2, T3 subs) #2798

Open
1 task done
Marstead opened this issue Sep 10, 2024 · 0 comments
Open
1 task done
Assignees
Labels
Bug A defect in the app Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release

Comments

@Marstead
Copy link

Marstead commented Sep 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When Firebot attempts to disburse bonus currency for any of the default Twitch roles like T1, T2, T3 sub or Streamer, it does not disburse anything except the base currency amount. This is true both when the bot is disbursing currency normally via the Currency tab and through custom commands that add currency to the Streamer and T1, T2, or T3 subs.

Expected Behavior

I expect when I have set a bonus value in the Currency tab for T1, T2, or T3 subs, that it will disburse bonus currency to these users, in addition to the base currency amount.

Steps To Reproduce

  1. Enable debug mode for more robust logging.
  2. Create or modify a currency and set any value in the fields for T1, T2, and T3 subs. (And streamer, if you like)
  3. Set the currency to disburse regularly enough for you to notice (1 point per 1 minute works)
  4. Monitor the log file for the disbursal to occur. You'll see that custom roles will correctly receive bonus currency, but Twitch-native roles will not.
  5. You can repeat the test by making a custom command that disburses currency. Update currency, add, "Online Users in Role", select T1 Sub, T2 Sub, T3 Sub, Streamer, run the command. No currency will be disbursed.

I have tested this with a wiped database that only contains "natural" viewers idling in chat (so no importing either via the vanilla tool or script import). It seems these multipliers simply don't work.

Version

5.63.2

What operating system are you using Firebot on?

Windows 10

Relevant log output

[2024-09-10 03:54:01.0017] - debug: [v5.63.2] Paying out 1 currency (e0ac7de0-6d65-11ef-a162-8b5c2788abaf) for online viewers:
[2024-09-10 03:54:01.0017] - debug: [v5.63.2] role ids 
[ 'tier1' ]
[2024-09-10 03:54:01.0017] - debug: [v5.63.2] user ids
[2024-09-10 03:54:01.0021] - debug: [v5.63.2] Paying out 1 currency (e0ac7de0-6d65-11ef-a162-8b5c2788abaf) for online viewers:
[2024-09-10 03:54:01.0021] - debug: [v5.63.2] role ids 
[ 'tier2' ]
[2024-09-10 03:54:01.0021] - debug: [v5.63.2] user ids
[2024-09-10 03:54:01.0024] - debug: [v5.63.2] Paying out 1 currency (e0ac7de0-6d65-11ef-a162-8b5c2788abaf) for online viewers:
[2024-09-10 03:54:01.0024] - debug: [v5.63.2] role ids 
[ 'tier3' ]
[2024-09-10 03:54:01.0024] - debug: [v5.63.2] user ids

Contact Details (Optional)

Marstead

@Marstead Marstead added the Bug A defect in the app label Sep 10, 2024
@CaveMobster CaveMobster self-assigned this Sep 26, 2024
CaveMobster added a commit that referenced this issue Sep 26, 2024
@CaveMobster CaveMobster added Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release
Projects
Status: Release Pending
Status: Release Pending
Development

No branches or pull requests

2 participants