Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Offline Currency "0" Payouts Prevent Other Currencies from Offline Payouts #2796

Open
CrowbarToolsRobot opened this issue Sep 10, 2024 · 0 comments
Open

[Bug] Offline Currency "0" Payouts Prevent Other Currencies from Offline Payouts #2796

CrowbarToolsRobot opened this issue Sep 10, 2024 · 0 comments
Labels
Bug A defect in the app Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review.

Comments

@CrowbarToolsRobot
Copy link
Collaborator

Description

Any currency with a zero offline payout rate inhibits later-modified currencies from paying out while offline.

Steps to Reproduce

  1. Add a currency with a 0 offline payout.
  2. Add another currency with a 1 offline payout.
  3. Wait for currency timer to engage.

Expected Behavior

Second currency should get paid out while offline.

Firebot Version

v5.63.2

Submitted By

phroggie

Created via Discord.
@CrowbarToolsRobot CrowbarToolsRobot added the Bug A defect in the app label Sep 10, 2024
phroggster added a commit to phroggster/Firebot that referenced this issue Sep 10, 2024
@phroggster
fix: Offline Currency Payout Improvement
d7f11ca 
- Currency payouts would stop paying out while offline once any currency
  had a zero offline payout.
- Changed it to keep checking additional currencies.
- Issue crowbartools#2796
@phroggster phroggster mentioned this issue Sep 10, 2024
Open
@phroggster phroggster added Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review. labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A defect in the app Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review.
Projects
Firebot
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phroggster @CrowbarToolsRobot