horizon: Add SSL protocol option. #2437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
reviewed
Mar 17, 2021
dirkmueller
reviewed
Mar 17, 2021
dirkmueller
reviewed
Mar 17, 2021
crowbar_framework/app/views/barclamp/horizon/_edit_attributes.html.haml
Outdated
Show resolved
Hide resolved
dirkmueller
reviewed
Mar 29, 2021
dirkmueller
reviewed
Mar 29, 2021
| @@ -0,0 +1,9 @@ | |||
| def upgrade(template_attrs, template_deployment, attrs, deployment) | |||
| attrs["apache"]["ssl_protocol"] = template_attrs["apache"]["ssl_protocol"] | |||
There was a problem hiding this comment.
please do this only if attrs["apache"]["ssl_protocol"] is not already defined (because of a backported earlier migration.
There was a problem hiding this comment.
I'm not sure which is preferred way, if unless attrs.key? or if attr["..."].nil?, but the former looks better.
dirkmueller
reviewed
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current setting in cookbook templates exclude only SSLv2 and SSLv3.
SSLProtocol all -SSLv2 -SSLv3but in these days TLSv1.0 protocol is already deprecated, so it will be nice to have any option how to disable this old protocol.
We can add protocol option (this PR) and keep it up to user to select which protocol he wants, disable TLSv1.0 in default settings or both of them.