swift: Remove deprecated option allow_versions #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the comment from Matt, there might be a risk to deprecate this option if customer enabling 'allow_versions' before Kilo release(https://gerrit.suse.provo.cloud/#/c/5474/). Need further update from him before merging this PR. |
|
Thanks @kwu83tw, let me go work on an upstream patch and/or talk to other upstream cores to cover this. I'll report back here, and on the gerrit patch once something is decided and/or landed and backported ;) Maybe we should add the 'do not merge yet' label. |
|
I've raised a bug upstream to track this issue: https://bugs.launchpad.net/swift/+bug/1811044 |
Start to log deprecation warning since Queens[1]. swift-c: Option allow_versions is deprecated. Configure the versioned_writes middleware in the proxy-server instead. This option will be ignored in a future release. Please refer the object versioning documentation for more information[2]. [1] https://docs.openstack.org/releasenotes/swift/queens.html#relnotes-2-16-0-stable-queens [2] https://docs.openstack.org/swift/latest/overview_object_versioning.html
cmurphy
requested changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to log deprecation warning since Queens[1].
swift-c: Option allow_versions is deprecated. Configure the versioned_writes
middleware in the proxy-server instead. This option will be ignored in a future
release. Please refer the object versioning documentation for more
information[2].
[1] https://docs.openstack.org/releasenotes/swift/queens.html#relnotes-2-16-0-stable-queens
[2] https://docs.openstack.org/swift/latest/overview_object_versioning.html