[Bug]: TokenPassword resource stuck when corresponding Token is deleted first

[felfa01]

Is there an existing issue for this?

• I have searched the existing issues

Affected Resource(s)

containerregistry.azure.upbound.io/v1beta1 - TokenPassword

Resource MRs required to reproduce the bug

No response

Steps to Reproduce

1. Create a Token
2. Create a TokenPassword with spec.forProvider.containerRegistryTokenIdRef pointing towards the Token
3. Delete Token
4. Delete TokenPassword

For our setup, we have both these resources in an ArgoCD Application so we can't really control the order in which they are deleted (deleting tokenpassword first and then token works fine).

What happened?

TokenPassword is stuck and not deleted due to 404s towards the token in the ACR

Relevant Error Output Snippet

conditions:
  - lastTransitionTime: "2024-07-04T10:53:53Z"
    message: |-
      observe failed: failed to observe the resource: [{0 retrieving Token (Subscription: "xxxxx"
      Resource Group Name: "registry"
      Registry Name: "registry"
      Token Name: "read"): unexpected status 404 with error: ResourceNotFound: The resource read could not be found. retrieving Token (Subscription: "xxxxx"
      Resource Group Name: "registry"
      Registry Name: "registry"
      Token Name: "read"): unexpected status 404 with error: ResourceNotFound: The resource read could not be found. []}]
    reason: ReconcileError
    status: "False"
    type: Synced
  - lastTransitionTime: "2024-07-04T10:53:41Z"
    reason: Deleting
    status: "False"
    type: Ready
  - lastTransitionTime: "2024-07-04T10:53:52Z"
    message: 'async delete failed: failed to delete the resource: [{0 deleting Container
      Registry Token Password: (Password Name "password" / Token Name "read"
      / Registry Name "registry" / Resource Group "registry"): performing
      Update: unexpected status 404 with error: ResourceNotFound: The resource read
      could not be found. deleting Container Registry Token Password: (Password Name
      "password" / Token Name "read" / Registry Name "registry"
      / Resource Group "registry"): performing Update: unexpected status 404 with
      error: ResourceNotFound: The resource read could not be found.
      []}]'

Crossplane Version

1.15.1

Provider Version

1.0.1

Kubernetes Version

1.29

Kubernetes Distribution

AKS

Additional Info

No response

[illrill]

I have the exact same problem! Need to manually remove the finalizer on the TokenPassword MR to get it resolved

[github-actions]

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

[illrill]

/fresh