Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get_route_maps not working starting 202211 #14

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: get_route_maps not working starting 202211 #14

merged 1 commit into from
Oct 3, 2024

Conversation

kpetremann
Copy link
Contributor

@kpetremann kpetremann commented Oct 3, 2024 •
edited
Loading

starting 202211, the hacky command has an issue:

$ show route-map ?
  <cr>  
  WORD  route-map name
     
     RM-BGP_PROV_2M203108
  json  JavaScript Object Notation

Let's stop doing crappy hack, and use a proper query instead :)

arn-alt
arn-alt previously approved these changes Oct 3, 2024
View reviewed changes
@kpetremann
fix: get_route_maps not working starting 202211
d87dfd3 
Let's stop doing crappy hack, and use a proper query instead :)
@kpetremann
Copy link
Contributor Author

tested on 201911 and 202205

@kpetremann kpetremann requested a review from a team October 3, 2024 14:23
mathieulaunay
mathieulaunay approved these changes Oct 3, 2024
View reviewed changes
Copy link

@mathieulaunay mathieulaunay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@kpetremann kpetremann merged commit 28a7447 into criteo:main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieulaunay mathieulaunay mathieulaunay approved these changes

@arn-alt arn-alt arn-alt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpetremann @arn-alt @mathieulaunay