Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing validation of logout request functions #523

Open
Lunkentuss opened this issue May 31, 2023 · 0 comments
Open

Add missing validation of logout request functions #523

Lunkentuss opened this issue May 31, 2023 · 0 comments

Comments

@Lunkentuss
Copy link

Currently, there are multiple functions implemented that validates SAML logout responses, for example:

//service_provider.go
func (sp *ServiceProvider) ValidateLogoutResponseRequest(req *http.Request) error {...}
func (sp *ServiceProvider) ValidateLogoutResponseForm(postFormData string) error {..}
func (sp *ServiceProvider) ValidateLogoutResponseRedirect(queryParameterData string) error {...}

. However, there are no corresponding functions for validating logout requests. I would suggest to add the following public functions:

//service_provider.go
func (sp *ServiceProvider) ValidateLogoutRequestRequest(req *http.Request) error {...}
func (sp *ServiceProvider) ValidateLogoutRequestForm(postFormData string) error {...}
func (sp *ServiceProvider) ValidateLogoutRequestRedirect(queryParameterData string) error {...}

, in order to support validation of logout requests.

Thanks in advance!

@Lunkentuss Lunkentuss changed the title Add missing validation of logout requests functions Add missing validation of logout request functions May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant