Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bilateral_slice #20

Open
lichen120 opened this issue Oct 29, 2021 · 12 comments
Open

bilateral_slice #20

lichen120 opened this issue Oct 29, 2021 · 12 comments

Comments

@lichen120
Copy link

how to use the bilateral_slice.cu.cc

@creotiv
Copy link
Owner

creotiv commented Oct 29, 2021 via email

@lichen120
Copy link
Author

lichen120 commented Nov 1, 2021 via email

@creotiv
Copy link
Owner

creotiv commented Nov 1, 2021 via email

@lichen120
Copy link
Author

PyTorch native modules can replace the bilateral_slice with the same operation?grid_upsample?

@lichen120
Copy link
Author

lichen120 commented Nov 1, 2021 via email

@creotiv
Copy link
Owner

creotiv commented Nov 1, 2021

@lichen120 im not compared them side by side, but based on logic F.grid_sample works in the same way
https://github.com/creotiv/hdrnet-pytorch/blob/master/model.py#L38

@lichen120
Copy link
Author

lichen120 commented Nov 1, 2021 via email

@creotiv
Copy link
Owner

creotiv commented Nov 1, 2021

@lichen120 as we figured out yes, but docs are shit. Basically when u use 5D input array for 3d map, and use bilinear interpolation, trilinear interpolation used. Here is discussion: pytorch/pytorch#5565

@creotiv
Copy link
Owner

creotiv commented Feb 11, 2022

ive added bilateral_slice from original repo compiled for jit. But still has some problems with optimization for some reason

@shacharp
Copy link

shacharp commented Jul 31, 2022

ive added bilateral_slice from original repo compiled for jit. But still has some problems with optimization for some reason

Hey, did you manage to fix those problems?

And note that slice.py uses now torch greater than your 1.1.0 in the requirements (e.g. torch.concat was introduced in torch 1.10.0, and also a problem in meshgrid() that doesn't have 'indexing' argument in 1.1.0 but in 1.10.0 does)

@creotiv
Copy link
Owner

creotiv commented Aug 1, 2022

@shacharp we in war with russia right now, so dont have time on this. But last time i was trying to fix this i added jit compiled code from original repo, but still with no luck. but slicing working ok.
I think to understand real problem in this code we need to debug it outputs layer by layer with getting original output as a target. Beside this i really dont know what to do, as i checked everething(

@ProNoobLi
Copy link

But still has some problems with optimization for some reason

Hey, bro, How are you right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants