Replace use of System.out/System.err with SLF4J Logging #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Operation outputs have been unchanged as these should be visible via CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Operation outputs have been unchanged as these should be visible via CLI
Description
Various parts of the tooling log errors / warnings to System.out instead of a logging framework. This makes it difficult to redirect logging to a file or to distinguish errors from the actual output.
This change routes output to the SLF4J logging framework, except for in cases where the outputs are required by the CLI.
System.outis used for logging as opposed to slf4j #262By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0