Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception propagates out of R4MeasureService.ensureSupplementalDataElementSearchParameter #451

Closed
smailliwcs opened this issue Apr 16, 2024 · 1 comment
Assignees

Comments

@smailliwcs
Copy link

R4MeasureService.ensureSupplementalDataElementSearchParameter is written to swallow NotImplementedOperationException:

} catch (NotImplementedOperationException e) {
log.warn(
"Error creating supplemental data search parameter. This may be due to the server not supporting transactions.",
e);
}

But in at least one case (InMemoryFhirRepository), the exception thrown by the repository is a NotImplementedException:

throw new NotImplementedException("The transaction operation is not currently supported");

Should the thrown/caught exception types be compatible here? Prior to #435, R4MeasureService caught UnsupportedOperationException, which did swallow the (subclassing) NotImplementedException.

smailliwcs added a commit to lantanagroup/link-cloud that referenced this issue May 9, 2024
This works around an issue with the latest `cqf-fhir` libraries:

cqframework/clinical-reasoning#451

For now, use version 3.0.0 of those libraries, which depend transitively
on HAPI 7.0.0 (which we declare explicitly for compatibility).
@c-schuler c-schuler self-assigned this Sep 13, 2024
JPercival pushed a commit that referenced this issue Sep 13, 2024
…ception (#514)

Updated to use HAPI's unsupported operation exception

Fix for #451
@JPercival
Copy link
Contributor

Resolved by #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants