-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/161 #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think we should aim in having a smaller centralized solution for this problem. It seems we're solving it multiple times across the app. We can discuss ways of doing that, please let me know if you have any doubt.
Hey Alex, really good input here. The PR is becoming pretty big so I believe its best to leave some of the refactorings for separate PRs. Either way, it would be great to have some feedback on the work here. Thank you again, good stuff |
This should offer an MVP for showing times in 12 hour format.
The user can decide this in the settings menu via the dropdown or override locally in the viewers by adding format=12 or format=24 to the URL parameters
time entry and in app times are all in 24 hours. will not redesign since the components are under review with #55