Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/161 #186

Merged
merged 33 commits into from
Aug 30, 2022
Merged

Feat/161 #186

merged 33 commits into from
Aug 30, 2022

Conversation

cpvalente
Copy link
Owner

This should offer an MVP for showing times in 12 hour format.
The user can decide this in the settings menu via the dropdown or override locally in the viewers by adding format=12 or format=24 to the URL parameters

time entry and in app times are all in 24 hours. will not redesign since the components are under review with #55

@cpvalente cpvalente linked an issue Jul 31, 2022 that may be closed by this pull request
Copy link
Contributor

@alexrohleder alexrohleder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think we should aim in having a smaller centralized solution for this problem. It seems we're solving it multiple times across the app. We can discuss ways of doing that, please let me know if you have any doubt.

client/src/common/components/views/TodayItem.jsx Outdated Show resolved Hide resolved
client/src/common/utils/eventsManager.js Outdated Show resolved Hide resolved
client/src/common/components/views/TodayItem.jsx Outdated Show resolved Hide resolved
client/src/common/utils/eventsManager.js Outdated Show resolved Hide resolved
client/src/features/viewers/countdown/Countdown.jsx Outdated Show resolved Hide resolved
client/src/features/viewers/foh/Public.jsx Outdated Show resolved Hide resolved
client/src/features/viewers/foh/Public.jsx Outdated Show resolved Hide resolved
client/src/features/viewers/ViewWrapper.jsx Outdated Show resolved Hide resolved
client/src/features/modals/AppSettingsModal.jsx Outdated Show resolved Hide resolved
client/src/features/modals/AppSettingsModal.jsx Outdated Show resolved Hide resolved
client/src/features/modals/AppSettingsModal.jsx Outdated Show resolved Hide resolved
client/src/features/modals/AppSettingsModal.jsx Outdated Show resolved Hide resolved
@cpvalente
Copy link
Owner Author

Hey Alex, really good input here.
I have made some changes to the state and centralised the time formatting.

The PR is becoming pretty big so I believe its best to leave some of the refactorings for separate PRs.
For now I will create branches for refactoring forms, we will get to the rest eventually

Either way, it would be great to have some feedback on the work here. Thank you again, good stuff

@cpvalente cpvalente merged commit 0651777 into master Aug 30, 2022
@cpvalente cpvalente deleted the feat/161 branch August 30, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

12 Hour Time
2 participants