Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer 2 seconds off #1285

Open
TuomasJaa opened this issue Oct 22, 2024 · 3 comments
Open

Timer 2 seconds off #1285

TuomasJaa opened this issue Oct 22, 2024 · 3 comments

Comments

@TuomasJaa
Copy link

When starting short 5 or 30 second event. The clock starts at "set time" - 2 seconds and then when time is running low timer goes -2 before the time is up.
So counting is two seconds off, overall duration is ok.

@cpvalente
Copy link
Owner

Hi, thank you for taking the time to report this.

It is unclear to us what is actually being reported here.

From what I understand, you say that the event started 2 seconds before it should, meaning that it finished 2 seconds earlier. Is this correct?

If so, there are two ways the event can start

a) start with roll: with roll mode active, the event will start at schedule, give or take a few ms. we were unable to find any issues with this

b) start manually: this could well be the case and the issue here is in expectation. an event starts whenever it is started, unrelated to the schedule. In that sense, the schedule and the runtime are different things. If you were to start an event earlier, it would naturally finish earlier

Did any of these help?
It may be that I misunderstood your question and there is some issue we should investigate, please let me know

@TuomasJaa
Copy link
Author

I Hope this video explains this better
https://photos.app.goo.gl/tEsvyPgGnHXFFqkw6

@cpvalente
Copy link
Owner

I Hope this video explains this better https://photos.app.goo.gl/tEsvyPgGnHXFFqkw6

Hi, thank you very much for this. It definitely clarifies

First thing I saw, is that you are in a very old version of the app. I would suggest that you upgrade if it is possible to you

From the rest there were two points that stood out

  • progress bar is late
  • there are 2 x 0 points

The progress bar animates over 1 seconds, so it is always a bit late.
In this interface, the progress bar is completely cosmetic. The 0 time in Ontime is precise, regardless of this element.
I will speed up the animation to improve this.

As for the double 0 seconds, what you see in Ontime's interface is a truncated time string with no rounding. ie
00m05s32ms is shown as 00m05s
With that in mind, the countdown goes like
+0m05.000 -> 00:05 (initial timer)
+0m04.900 -> 00:04 (ticks every 32ms)
...
+0m00.032 -> 00:00
-0m00.032 -> -00:00
...

you can see here another thread where we discuss here
#1025 (comment)

This to say, that this is something we spent a long time thinking about, and have opted for the current behaviour.
However, if there is an inclination from users that our decision is incorrect, I am happy to bring this back to the table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants