Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit multiple events #1221

Open
cpvalente opened this issue Sep 21, 2024 · 0 comments
Open

Edit multiple events #1221

cpvalente opened this issue Sep 21, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@cpvalente
Copy link
Owner

Currently in the editor interface, the user can select any event and edit its contents on the rightmost panel.

However, if the user selects multiple events, we are unable to handle editing on selections that contain multiple elements

Feature description

We would like to allow users to make changes to the entire selection

  • the user will select events in the <Rundown>
  • if there are multiple events selected, the <EventEditor> will average the result as detailed below
  • changing a value in one of the inputs, should make the mutation for the entire selection. We can leverage the batchEdit endpoint for this

Averaging of results

When multiple events are selected we show a field as

  • empty if any of the values differ
  • the original value if all values match

This imposes a challenge for boolean toggles and select fields, where we will need to create indeterminate states.
As a proposal, we could potentially

  • changing switch to checkbox with indeterminate mode
  • adding a new value to selects [Multiple] for handling this edge case
  • adding a new colour (circle with question mark)

Potential Caveats

Additional context

There have been a few developers trying this out before (see #874 #1186). The usual road blocks are related to performance.

The rundown performance is ... fragile ... and we should make sure to avoid unnecessary renders. This can be properly tested by having a few hundred events (we test with up to 900 elements)

The rundown is the core of the application, we prefer not having this feature if we cannot guarantee acceptable performance

@cpvalente cpvalente added the good first issue Good for newcomers label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant