Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 're2' to v2023.03.01 #722

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

JamesEggleton
Copy link

Includes versions: 2022.06.01, 2022.12.01, 2023.02.01, 2023.03.01

More recent versions introduce a dependency on Google Abseil, so will require a fork.

  • I've followed this guide
    step by step carefully. Yes

Tested locally on macOS 13.6 with Apple clang 15.0.0 .

Includes versions: 2022.06.01, 2022.12.01, 2023.02.01, 2023.03.01

Newer versions introduce a dependency on Google Abseil, so will require a fork.
Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once question is answered.

fork already exists: https://github.com/cpp-pm/re2

see: #713 (comment)

cmake/projects/re2/hunter.cmake Show resolved Hide resolved
@NeroBurner NeroBurner merged commit 5f6ab17 into cpp-pm:master Nov 1, 2023
17 of 19 checks passed
@JamesEggleton JamesEggleton deleted the pr.re2 branch November 8, 2023 21:51
@NeroBurner
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants