Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about updating copyright notes to the manual #601

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

craffael
Copy link

  • I've checked this Git style guide. Yes
  • I've checked this CMake style guide. Yes
  • My change will work with CMake 3.2 (minimum requirement for Hunter). Yes
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. *Yes

As @NeroBurner pointed out in #600 one should update the copyright notices when a new package is created. This PR points this out to the user in the guide to create a new package.

@NeroBurner
Copy link

@rbsheth could you have a look at this. I'm not sure what exactly the copyright notice in the new packages should be

:emphasize-lines: 10, 12, 14, 16
:emphasize-lines: 1, 13, 15, 17, 19

# Copyright (c) 2016-2020, Rahul Sheth, Ruslan Baratov
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 2022 at the least. Perhaps it is better to insert <your-name-here> or some kind of placeholder so that contributors can put their names on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants