Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Health] Add support for saving blood pressure as a correlation(ios) #919

Merged
merged 12 commits into from
Apr 3, 2024
Merged

[Health] Add support for saving blood pressure as a correlation(ios) #919

merged 12 commits into from
Apr 3, 2024

Conversation

ikoamu
Copy link
Contributor

@ikoamu ikoamu commented Mar 17, 2024 •
edited
Loading

close #550

@bardram bardram self-assigned this Mar 25, 2024
@bardram bardram self-requested a review March 25, 2024 15:27
bardram
bardram reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@bardram bardram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we would do this?

@ikoamu
Copy link
Contributor Author

ikoamu commented Mar 26, 2024

When blood pressure is not registered as a correlation, the data is not displayed in the Health Care list, but only in the graph screen.
Registering blood pressure as a correlation will resolve this issue.

Before modification
health_ios_before_blood_pressure_graph health_ios_before_blood_pressure_home health_ios_before_blood_pressures_page

After modification
health_ios_after_blood_pressure_graph health_ios_after_blood_pressure_home health_ios_after_blood_pressure_details health_ios_after_blood_pressures_page

@ikoamu ikoamu requested a review from bardram March 26, 2024 08:24
@bardram
Copy link
Contributor

bardram commented Mar 30, 2024

ok - but since we've updated the plugin with other PRs lately (plus fixed a lot of linter problem), I would like to have this PR updated to be able to merge with the latest master branch (which has been released as version 10.1.1.).

bardram
bardram requested changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@bardram bardram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR to merge with latest master branch.

@ikoamu ikoamu requested a review from bardram March 31, 2024 15:21
@ikoamu
Copy link
Contributor Author

ikoamu commented Mar 31, 2024

Conflicts have been resolved, please confirm. Thank you.

@bardram bardram changed the base branch from master to bardram/health-update April 3, 2024 11:03
@bardram bardram merged commit f6326cb into cph-cachet:bardram/health-update Apr 3, 2024
1 check passed
bardram added a commit that referenced this pull request Apr 3, 2024
@bardram
PR #919 & support for HealthPlatformType
122b3ae
@bardram bardram mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bardram bardram bardram approved these changes

Assignees

@bardram bardram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[health 3.4.4] No way to add Correlation
4 participants
@ikoamu @bardram @bruce3x @tm-hirai