[health] Prevent app crash on Android when Health Connect SDK is unavailable #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g and reading/writing data
|
I will review this. But in general, I'm not a big fan of all the exceptions being thrown, so I will look into reducing this. |
bardram
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
I've updated the plugin to more gracefull error handling and making it throw less errors. Also updated the demo app to use the method to check for Health Connect and only allow accesss to setter / getters (buttons) when HC is available.
Update to docs, incl. README.
|
Also upgraded to the type-safe JSON serialization in carp_serialization v. 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for SDK status before reading, writing or otherwise interacting with Health Connect. If HC is not available, we will throw an exception to say that HC needs to be installed.
Closes #1043.