Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unit coverage for poll legacy #97

Open
1 of 2 tasks
mfw78 opened this issue Oct 6, 2023 · 1 comment
Open
1 of 2 tasks

test: unit coverage for poll legacy #97

mfw78 opened this issue Oct 6, 2023 · 1 comment
Labels
test Issue related to the test suite with no expected consequence to production code

Comments

@mfw78
Copy link
Contributor

mfw78 commented Oct 6, 2023 •
edited
Loading

Background

It's frustrating working on the polling legacy logic as it is detailed and lacks unit testing, inhibiting robustness / trustworthiness.

Details

Implement a test harness for unit testing the legacy polling logic. This should be accomplished using jest test harnesses with mock for the getTradeableOrderWithSignature, and unit testing for customErrorDecode.

Acceptance criteria

  • Test coverage of customErrorDecode
  • Happy path test coverage of getTradeableOrderWithSignature
@mfw78 mfw78 added test Issue related to the test suite with no expected consequence to production code E:1.2: Watch Tower Service https://github.com/cowprotocol/pm/issues/8 labels Oct 6, 2023
@mfw78 mfw78 changed the title test: unit coverage for customErrorDecode test: unit coverage for poll legacy Oct 6, 2023
@mfw78 mfw78 mentioned this issue Oct 6, 2023
Merged
1 task
@anxolin
Copy link
Contributor

anxolin commented Oct 6, 2023

I wonder if we should just do this directly in the SDK as part of creating the GenericConditionalOrder

@mfw78 mfw78 removed the E:1.2: Watch Tower Service https://github.com/cowprotocol/pm/issues/8 label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issue related to the test suite with no expected consequence to production code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anxolin @mfw78