Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quote): add smartSlippage property to quote #64

Merged
merged 6 commits into from
Sep 5, 2024
Merged

feat(quote): add smartSlippage property to quote #64

merged 6 commits into from
Sep 5, 2024

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Sep 4, 2024 •
edited
Loading

Summary

  • Add quote v1.1.0 with smartQuote smartSlippage boolean property
  • Add appData v1.2.0 using the new quote version

Testing

Unit tests

@alfetopito alfetopito self-assigned this Sep 4, 2024
@alfetopito alfetopito requested a review from a team September 4, 2024 15:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@fleupold
Copy link

fleupold commented Sep 4, 2024

Can we call it smartSlipage or autoSlippage instead of quote?

shoom3301
shoom3301 reviewed Sep 5, 2024
View reviewed changes
src/schemas/v1.2.0.json
@@ -0,0 +1,78 @@
{
"$id": "https://cowswap.exchange/schemas/app-data/v1.2.0.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use ens domain here? (Not now, maybe in the future)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It still uses the domain from the before times. As you say, not a must as this point, but we should.

shoom3301
shoom3301 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@shoom3301 shoom3301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically all good

@alfetopito
Copy link
Collaborator Author

Can we call it smartSlipage or autoSlippage instead of quote?

We sure can, will update.

@alfetopito alfetopito merged commit 6cd7e05 into main Sep 5, 2024
5 of 6 checks passed
@alfetopito alfetopito deleted the feat/quote-smartSlippage branch September 5, 2024 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfetopito @fleupold @shoom3301