Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach / replace oscillator from base shield #2

Open
2 of 5 tasks
olemis opened this issue May 5, 2020 · 4 comments
Open
2 of 5 tasks

Detach / replace oscillator from base shield #2

olemis opened this issue May 5, 2020 · 4 comments
Assignees
Labels
calibration Required for ARMEE shield calibration purposes enhancement New feature or request modelling Requires 3D modeling shield-oscillator Shield to hold A.R.M.E.E pneumatic oscillator
Milestone

Comments

@olemis
Copy link
Member

olemis commented May 5, 2020

Is your design request related to a problem? Please describe.
Make more efficient use of material when materializing 3D base shield. Allow for detaching

Target models

Model version: 17bac4b

Describe the solution you'd like
Provide the means for detaching ond and replacing it .

  • Add https://github.com/covid19elec/ARMEE_Ventilator_1.0 as submodule
  • Include recursive submodule initialization in repository README getting started instructions
  • Add generic oscillator slot in bottom shield
  • Parameterized versions of ARMEE oscillators including screws (or whatever other means needed to attach them on to base slot)
  • Simple solution to adapt an already 3D printed ARMEE oscillator for it to be attached on to base shield . Slight modifications using e.g. rotary tools of materialized ARMEE shields should be allowed but avoided whenever possible.

Describe alternatives you've considered
Currently the two base shield models look like realizations of a parametric shield base model instantiated for one specific oscillator in each case . That's the only part that changes. hat approached is correct as well so no need to discard it , just parameterize it.

Additional context
In some countries there quite a few PLA material to print prototypes . It should be used eficiently , and some FDM prototypes already printed .

@olemis olemis added enhancement New feature or request modelling Requires 3D modeling shield-oscillator Shield to hold A.R.M.E.E pneumatic oscillator labels May 5, 2020
@olemis olemis added the calibration Required for ARMEE shield calibration purposes label May 5, 2020
@olemis
Copy link
Member Author

olemis commented May 5, 2020

Parameterized A.R.M.E.E models should be forwarded as enhancement pull requests onto ARMEE project . Please work in https://github.com/covid19elec/ARMEE_Ventilator_1.0 fork and submit from there.

@olemis
Copy link
Member Author

olemis commented May 5, 2020

@olemis indeed , any Github repository is ok for sending PR onto ARMEE repository as long as changes may be pulled back into https://github.com/covid19elec/ARMEE_Ventilator_1.0 which is the one that will be added as submodule in this repository.

@olemis olemis added this to the v0.0.1 milestone May 5, 2020
olemis added a commit that referenced this issue May 5, 2020
... models needed for instantiating parameterized versions of ARMEE pneumatic oscillators
@olemis
Copy link
Member Author

olemis commented May 5, 2020

@olemis Jose I guess we can move in parallel with the work on the shields , by doing this 👆it'd be possible to replace one oscillator with the next to try while no modifications required on shield

@olemis
Copy link
Member Author

olemis commented May 6, 2020

This feature is compulsory in case of adopting the strategy of swapping non-configurable pneumatic oscillator units for switching to different ventilation parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calibration Required for ARMEE shield calibration purposes enhancement New feature or request modelling Requires 3D modeling shield-oscillator Shield to hold A.R.M.E.E pneumatic oscillator
Projects
None yet
Development

No branches or pull requests

2 participants