docs(headless-ssr-commerce-samples): add multiple listing pages #4635
Conversation
| context: { | ||
| language: 'en', | ||
| country: 'US', | ||
| currency: 'USD', | ||
| view: { | ||
| url: '?', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This is awkward to have to define the view.url here in a search page. Ideally we would make it so when fetchStaticState is called from a searchEngineDefinition not every type is required. I am not sure how to achieve this tho. We could also just make the view type optional.
There was a problem hiding this comment.
Talked with Oli and he said it is fine. We should set the url everywhere. CAPI could theoretically use the url defined in search somewhere down the line.
| images: { | ||
| domains: ['images.barca.group'], | ||
| }, |
There was a problem hiding this comment.
This is just necessary to use nextjs <Image/>
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
alexprudhomme
changed the title
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
force-pushed
the
KIT-3707
branch
from
1611a45
to
1d8f07f
Compare
| context: { | ||
| language: 'en', | ||
| country: 'US', | ||
| currency: 'USD', | ||
| view: { | ||
| url: 'https://sports.barca.group/browse/promotions/ui-kit-testing', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Should we remove this from the require definition since it should always be added during fetchStaticState ?
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
https://coveord.atlassian.net/browse/KIT-3707